[pull] main from microsoft:main#762
Merged
Merged
Conversation
- Fix boundary condition in WebSocket frame header size calculation: `length > 2 ** 16` → `length >= 2 ** 16` - Per RFC 6455 Section 5.2, a payload of exactly 65536 bytes requires the 64-bit extended length field (16-bit unsigned max is 65535) - Add test for the exact boundary (2**16 bytes payload) Fixes #41142
#41124) only set `_webSocketMessages` if `content: 'embed'` for `content: 'attach'`, save the array as a `.json` also, unlike other requests that have a single response, a `WebSocket` can receive multiple frames, meaning that we don't finish the `Entry` until the `WebSocket` is closed, which delays when the captured frames are saved, so make sure to at least save what's already there if the recording is stopped before the `WebSocket` is closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )